Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gitsunmin] Week 6 Solutions #470

Merged
merged 9 commits into from
Sep 22, 2024
Merged

[gitsunmin] Week 6 Solutions #470

merged 9 commits into from
Sep 22, 2024

Conversation

gitsunmin
Copy link
Contributor

@gitsunmin gitsunmin commented Sep 18, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@gitsunmin gitsunmin self-assigned this Sep 18, 2024
@gitsunmin gitsunmin added the ts label Sep 18, 2024
Comment on lines +7 to +8
type OpeningBracket = '(' | '[' | '{';
type ClosingBracket = ')' | ']' | '}';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

타입스크립트의 강점을 십분 활용하고 계시는 군요 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 🙏

@gitsunmin gitsunmin marked this pull request as ready for review September 21, 2024 07:29
@gitsunmin gitsunmin requested a review from a team as a code owner September 21, 2024 07:29
Copy link
Contributor

@HC-kang HC-kang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 @gitsunmin 님!
이번 한 주도 고생 많으셨습니다!

* time complexity:
* - addWord: O(m)
* - search: O(26^m) in the worst case (with multiple wildcards) to O(m) in general cases.
* space complexity: O(n * m)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공간 복잡도도 메서드별로 개별적으로 평가 해 주시는 것이 좋지 않을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HC-kang 아 넵 공간 복잡도는 두 메서드가 모두 같아서 하나로 작성했었는데, 두 개로 나누어 작성해둘게요

@@ -0,0 +1,21 @@
/**
* https://leetcode.com/problems/longest-increasing-subsequence
* time complexity : O(n)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

비록 while 문 내에 별도 로직이 없더라도, 현재 코드상으로는 시간복잡도가 O(n^2)의 형태가 아닐까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 시간 복잡도를 잘못 계산한것같아요 수정했습니다! 감사합니다1

@gitsunmin gitsunmin changed the title [gitsunmin] Week 5 Solutions [gitsunmin] Week 6 Solutions Sep 22, 2024
@gitsunmin gitsunmin merged commit 94da0df into DaleStudy:main Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants