Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cloaking an item as itself #23

Open
wants to merge 1 commit into
base: 1.20.1
Choose a base branch
from

Conversation

Gronglegrowth
Copy link

Added a check to both item and block model cloaking to ensure they only actually run if the models are different. Before this change, trying to do this would crash with a stack overflow error,,,

this prevents a stack overflow crash if the models are the same
@DaFuqs
Copy link
Owner

DaFuqs commented Oct 1, 2024

While that solves this one problem, it kind of feels like a bandaid fix for one out of more issues. It still messes up when you cloak two items as one another or a->b->c

A fix that solves all issues, instead of just this single instance would make more sense.

@Gronglegrowth
Copy link
Author

I hadn't known there were more issues; I was only aware of this one. Something more comprehensive then would indeed be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants