Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use next/script and move AA script out of Head #736

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

Charles-Pham
Copy link
Contributor

@Charles-Pham Charles-Pham commented Oct 9, 2024

ADO-280112

Work towards and potential fix for 280112

Changelog - "fix:" for bug fixes, "feat:" for features. Read more about Conventional Commits at https://www.conventionalcommits.org/en/v1.0.0/#summary

Description of proposed changes:

Changed to not use <script> to import AA in Head since this isn't allowed (https://nextjs.org/docs/messages/no-script-tags-in-head-component) and moved it outside and used next/script instead.

What to test for/How to test

AA script should appear in the body instead of the head. Also, on monitoring the network activity there should only be one download of the AA script instead of two.

Additional Notes

@Charles-Pham Charles-Pham requested a review from a team as a code owner October 9, 2024 14:52
Copy link

github-actions bot commented Oct 9, 2024

Copy link
Contributor

@jhslater jhslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Charles-Pham Charles-Pham merged commit a2f9b78 into dev Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants