Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translations for subscriptions feature #3649

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

pilasou
Copy link
Contributor

@pilasou pilasou commented Nov 13, 2024

References

Description

Includes all french labels for subcriptions, plus a few other missing things.

Includes all french labels for subcriptions, plus 2 or 3 other missing things.
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Nov 13, 2024
@tdonohue tdonohue added this to the 9.0 milestone Nov 13, 2024
@pilasou
Copy link
Contributor Author

pilasou commented Nov 13, 2024

@tdonohue I do not know why, but one test seems to be stucked: "Build / tests (20.x) (pull_request)." It is running for nearly 3 hours now. Do I have a way to reset it ?

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank @pilasou ! Looks good and passes all tests now. Merging immediately.

@tdonohue tdonohue merged commit aec402e into DSpace:main Nov 13, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants