BitstreamAuthorizationsComponent: update selector and comment to correctly describe component's purpose #3619
Conversation
saschaszott
changed the title
saschaszott
changed the title
tdonohue
added
bug
1 APPROVAL
There was a problem hiding this comment.
👍 Thanks @saschaszott ! This is definitely correct. I was initially confused by the selector change, but I looked into it & it's correct too. More info on that in the comment below (for any other developers who stumble on this PR).
| @@ -19,7 +19,7 @@ import { DSpaceObject } from '../../core/shared/dspace-object.model'; | |||
| import { ResourcePoliciesComponent } from '../../shared/resource-policies/resource-policies.component'; | |||
|
|
|||
| @Component({ | |||
| selector: 'ds-collection-authorizations', | |||
| selector: 'ds-bitstream-authorizations', | |||
There was a problem hiding this comment.
This is very odd that this component has been using the wrong selector for so long (it seems to also be like this in 7.x and 8.x). Especially since we have a separate component that is also using `ds-collection-authorizations : https://github.com/DSpace/dspace-angular/blob/main/src/app/collection-page/edit-collection-page/collection-authorizations/collection-authorizations.component.ts#L18
This is definitely a bug. I was surprised it's not been found yet, but it seems that both of these components are only referenced via routes (e.g. this BitstreamAuthorizationComponent is loaded via bitstream-page-routes.ts). So, that's why we didn't notice this invalid selector earlier...the selector isn't being used right now.
|
Successfully created backport PR for |
|
Successfully created backport PR for |
tdonohue
removed
port to dspace-7_x
Description
Trivial RP that fixes an incorrect comment in
BitstreamAuthorizationsComponent.