[Port dspace-7_x] ORCID Login flow for private emails #3347
+3,372
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that this development has been funded by the ORCID Global Participation Fund.
main version #3355
dspace-8_x version #3349
References
Add references/links to any related issues or PRs. These may include:
Description
This PR introduces new component and features related to the ORCID login flow
Instructions for Reviewers
To review this PR you should follow the main flow described inisde the linked PR DSpace/DSpace#9846
List of changes in this PR:
The review-account page is composed mainly by a table that reviews the user details and allows the logged in user to override some values using the data provided by the ORCID external provider.
The external login page is composed by three parts:
The external provider’s data (ORCID in our case), rendered dynamically based on registration type provided by token
Depending on registration data, if no email is provided we render ds-provide-email component and ds-confirm-email otherwise.
Connecting to an existing account button, which opens a modal with login form. This button is present in all cases.
The informative text is also rendered based on the case (is the email present or not)
All the pages are guarded (
ReviewAccountGuard
&RegistrationTokenGuard
) in order to make sure the token exposed is valid and will provide the needed registration data, otherwise it will redirect to /404 .Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.