Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated cs messages following the lindat v5 and clarin-dspace v7 instance #3222

Merged
merged 9 commits into from
Nov 11, 2024

Conversation

milanmajchrak
Copy link
Contributor

Description

Some cs messages added by NTK in this commit: ca7a9cf weren't 100% correct. This PR aims to resolve some mistakes or start a discussion about the correct translation.

Instructions for Reviewers

Check the correct translation to Czech language.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@milanmajchrak milanmajchrak changed the title Updated cs messages following the lindat v5 and clarin-dspace v7 instance [WIP] Updated cs messages following the lindat v5 and clarin-dspace v7 instance Jul 26, 2024
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jul 26, 2024
@@ -4346,7 +4344,7 @@
"item.page.subject": "Klíčová slova",

// "item.page.uri": "URI",
"item.page.uri": "URI",
"item.page.uri": "Identifikátor",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

přeloži bych spíše jako "Permanentní odkaz" nebo "Permanentní identifikátor", protože se jedná typicky o Handle

Copy link

@dewi-g dewi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

našel jsem ještě drobné chybky, dva překlepy a pár drobných vylepšení, jinak se jedná o výborné úpravy

@@ -5378,7 +5375,7 @@
"mydspace.new-submission-external-short": "Importovat metadata",

// "mydspace.results.head": "Your submissions",
"mydspace.results.head": "Váš příspěvek",
"mydspace.results.head": "Vaše zázmany",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je zde napsané "zázmany" namísto "záznamy", prosím o opravu

@@ -5390,7 +5387,7 @@
"mydspace.results.no-collections": "Žádné kolekce",

// "mydspace.results.no-date": "No Date",
"mydspace.results.no-date": "Žádné datum",
"mydspace.results.no-date": "Žádny datum",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tuto změnu prosím revertnout, pravopisně správně je pvodní varianta "žádné datum"

@@ -1477,8 +1477,8 @@
// "bitstream.download.page": "Now downloading {{bitstream}}...",
"bitstream.download.page": "Nyní se stahuje {{bitstream}}..." ,

// "bitstream.download.page.back": "Back",
"bitstream.download.page.back": "Zpět" ,
// "bitstream.download.page.back": "Back" ,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pro úplnost prosím smazat mezeru navíc mezi koncem vozovek (") a čárkou (,)

@@ -4310,10 +4308,10 @@
"item.page.journal.search.title": "Články v tomto časopise",

// "item.page.link.full": "Full item page",
"item.page.link.full": "Úplný záznam",
"item.page.link.full": "Zobrazit celý záznam",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

podle mne by bylo lepší "Zobrazit úplný záznam"

// TODO Source message changed - Revise the translation
"submission.submit.title": "Nově podaný záznam",
"submission.submit.title": "Nový příspěvek",

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

řádek navíc

@@ -6913,7 +6910,7 @@
"search.filters.applied.f.subject": "Předmět",

// "search.filters.applied.f.submitter": "Submitter",
"search.filters.applied.f.submitter": "Vkladatel",
"search.filters.applied.f.submitter": "Předkladatel",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V předchozích verzích se používalo Odesílatel 🤷‍♂️

@@ -4936,7 +4934,7 @@
"iiif.page.doi": "Trvalý odkaz: ",

// "iiif.page.issue": "Issue: ",
"iiif.page.issue": "Číslo: ",
"iiif.page.issue": "Problém:",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tady mi chybí kontext (kde se to v tom IIIF ukazuje), nicméně v es.json je překlad, kterej odpovídá tomu původnímu českému Číslo: . Ono to bude asi spíš něco jako číslo vydání, než nahlašte problém, ne?

@@ -2940,7 +2939,7 @@
"error.top-level-communities": "Chyba při načítání komunit nejvyšší úrovně",

// "error.validation.license.notgranted": "You must grant this license to complete your submission. If you are unable to grant this license at this time you may save your work and return later or remove the submission.",
"error.validation.license.notgranted": "eslání. Pokud tuto licenci v tuto chvíli nemůžete udělit, můžete svou práci uložit a vrátit se k ní později nebo podání odstranit.",
"error.validation.license.notgranted": "Pro dokončení zaslání musíte udělit licenci. Pokud v tuto chvíli tuto licenci nemůžete udělit, můžete svou práci uložit a později se k svému příspěveku vrátit nebo jej smazat.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bez udělení licence nelze záznam dokončit. Pokud v tuto chvíli nemůžete licenci udělit, uložte svou práci a vraťte se k příspěveku později nebo jej smažte.

src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
src/assets/i18n/cs.json5 Show resolved Hide resolved
Copy link

@kosarko kosarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok

Copy link

@dewi-g dewi-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nabízím ke zvážení matoucí situaci u fazety "Hledat pod dohledem" a s tím souvisejícíh označení entity, která dohlíží.

@@ -7221,8 +7221,7 @@
"search.filters.filter.supervisedBy.placeholder": "Supervised By",

// "search.filters.filter.supervisedBy.label": "Search Supervised By",
// TODO New key - Add a translation
"search.filters.filter.supervisedBy.label": "Search Supervised By",
"search.filters.filter.supervisedBy.label": "Hledat pod dohledem",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to "Supervised by" je faseta podle které hledat, tak by mne napadalo spíš "Hledat podle dohlížitele" nebo "Hledat podle supervizora" (a to by znamenalo změnit výše přehlad "Supervised by") anebo "Hledat dohlížející autoritu"

Navrhovaný překlad totiž vyvolává dojem nějakého kontrolovaného hledání, což může být matoucí

Překlad "dohlížející autorita" ovšem může evokovat autoritní záznamy. Lepší překlad mne zatím nenapadá, tak nabízím ke zvážení

@@ -4221,10 +4221,10 @@
"workflow-item.search.result.notification.deleted.failure": "Při mazání příkazu supervize \"{{name}}\" došlo k chybě",

// "workflow-item.search.result.list.element.supervised-by": "Supervised by:",
"workflow-item.search.result.list.element.supervised-by": "Supervizován:",
"workflow-item.search.result.list.element.supervised-by": "Pod dohledem:",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V návaznosti na komentář níže by možná bylo žádoucí změnit na "Dohlížející autorita"


// "workflow-item.search.result.list.element.supervised.remove-tooltip": "Remove supervision group",
"workflow-item.search.result.list.element.supervised.remove-tooltip": "Odebrat skupinu supervize",
"workflow-item.search.result.list.element.supervised.remove-tooltip": "Odebrat skupinu dohledu",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

také v návaznosti na komentář níže, "Odebrat dohlížející autoritu"

Copy link

github-actions bot commented Nov 8, 2024

Hi @milanmajchrak,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Copy link

@kosarko kosarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Překlad "dohlížející autorita" ovšem může evokovat autoritní záznamy. Lepší překlad mne zatím nenapadá, tak nabízím ke zvážení

Souhlas, ale čte se to líp než "Hledat pod dohledem"...taky lepší nápad nemám. Asi uvidíme, jak moc si na to lidi budou stěžovat, že od toho čekají něco jiného...

👍

@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Nov 11, 2024
@tdonohue tdonohue added this to the 9.0 milestone Nov 11, 2024
@tdonohue
Copy link
Member

Merging as this is now at +1. Thanks @milanmajchrak !

@tdonohue tdonohue merged commit a097309 into DSpace:main Nov 11, 2024
13 checks passed
@tdonohue tdonohue changed the title [WIP] Updated cs messages following the lindat v5 and clarin-dspace v7 instance Updated cs messages following the lindat v5 and clarin-dspace v7 instance Nov 11, 2024
@dspace-bot
Copy link
Contributor

@dspace-bot
Copy link
Contributor

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants