Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2535 hide add more button submission if no disabled sections 7.x #2536

Conversation

MarieVerdonck
Copy link
Contributor

@MarieVerdonck MarieVerdonck commented Oct 4, 2023

References

Description

Hides the disabled [+Add More] button in top right corner of submission causing confusion

Instructions for Reviewers

With no disabled steps (default):

With disabled steps:

  • Set mandatory="false" in item-submission.xml: <step-definition id="traditionalpagetwo" mandatory="false"> on the default second describe step
  • Verify in submission of default submission form that the [+Add More] button in top right corner is now present again & contains a dropdown containing the second described step (if clicked adds that step to the submission)

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug component: submission 1 APPROVAL pull request only requires a single approval to merge port to main This PR needs to be ported to `main` branch for the next major release labels Oct 4, 2023
@tdonohue tdonohue added this to the 7.6.1 milestone Oct 4, 2023
@tdonohue tdonohue self-requested a review October 5, 2023 15:01
@alanorth
Copy link
Contributor

alanorth commented Oct 12, 2023

Thanks @MarieVerdonck! I tested the patch with no disabled submission form steps on DSpace 7.6. I confirm that I do not see the disabled "Add More" button, and that item submission works as usual.

I also tested with traditionalpagetwo disabled and the "Add More" button was present and item submission works as expected.

@alanorth alanorth merged commit 3cb23c1 into DSpace:dspace-7_x Oct 12, 2023
10 checks passed
@dspace-bot
Copy link
Contributor

@alanorth alanorth removed the port to main This PR needs to be ported to `main` branch for the next major release label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: submission
Projects
Development

Successfully merging this pull request may close these issues.

4 participants