Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port dspace-7_x] Move subscription button to DSO edit menu #2528

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

dspace-bot
Copy link
Contributor

Port of #2385 by @ybnd to dspace-7_x.

- Abstract away the different "subsections" ~ DSO type (the tests should not care about this)
  Instead, retrieve sections of interest by ID & assert whether they're there & how they should look
- Test separately for Communities, Collections & Items
- Test newly added menu section

(cherry picked from commit 18b7a9c)
@dspace-bot dspace-bot added 1 APPROVAL pull request only requires a single approval to merge bug integration: syndication feed Related to RSS / ATOM syndication feeds ux User Experience related works labels Sep 27, 2023
@alanorth alanorth merged commit 980e254 into dspace-7_x Sep 27, 2023
10 checks passed
@alanorth alanorth deleted the backport-2385-to-dspace-7_x branch September 27, 2023 07:56
@alanorth
Copy link
Contributor

Merging ASAP as this is a simple port of a patch that we already tested and merged on main, and it is passing all tests here on dspace-7_x.

@tdonohue tdonohue added this to the 7.6.1 milestone Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug integration: syndication feed Related to RSS / ATOM syndication feeds ux User Experience related works
Projects
Development

Successfully merging this pull request may close these issues.

4 participants