Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serbian (Latin) translation #2508

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Serbian (Latin) translation #2508

merged 4 commits into from
Sep 26, 2023

Conversation

imilos
Copy link
Contributor

@imilos imilos commented Sep 20, 2023

References

Description

Serbian (Latin) translation added.

Instructions for Reviewers

List of changes in this PR:

  • Added file sr-lat.json5
  • Modified default default config to include Serbian (Latin) translation.

@alanorth alanorth added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Sep 25, 2023
@alanorth
Copy link
Contributor

Thanks @imilos! I tested this patch and was able to switch to Serbian latin in the Angular user interface.

I notice that the order of languages in the drop down mostly alphabetical (at least for Latin script). Can you move Srpski (lat) up, above Suomi? Thanks.

@alanorth alanorth self-requested a review September 25, 2023 09:20
@imilos
Copy link
Contributor Author

imilos commented Sep 25, 2023

Thanks for your quick response @alanorth ! I moved Serbian (lat) just above Suomi, as you suggested. I also hope to have Serbian with Cyrillic script soon.

@alanorth alanorth merged commit cae831b into DSpace:main Sep 26, 2023
10 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@alanorth
Copy link
Contributor

@imilos Hvala! Looks good. Merging now (I squashed the commits into one).

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Sep 26, 2023
@tdonohue tdonohue added this to the 8.0 milestone Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants