Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename aletr-type.ts to alert-type.ts #2381

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

mirkoscherf
Copy link
Contributor

References

Add references/links to any related issues or PRs. These may include:

Description

Renamed aletr-type.ts to alert-type.ts and updated all corresponding imports.

Instructions for Reviewers

Simple refactoring to eliminate a typo.

List of changes in this PR:

  • Renamed aletr-type.ts to alert-type.ts
  • Changed all "import { AlertType } from '../../../shared/alert/aletr-type';" to 'import { AlertType } from "../../../shared/alert/alert-type';"

Checklist

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug code task 1 APPROVAL pull request only requires a single approval to merge labels Jul 20, 2023
@tdonohue tdonohue added this to the 7.6.1 milestone Jul 20, 2023
@tdonohue tdonohue self-requested a review July 27, 2023 14:22
@tdonohue tdonohue added the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Aug 2, 2023
@alanorth
Copy link
Contributor

alanorth commented Aug 3, 2023

Thanks @mirkoscherf. I tested this by building and running the Angular frontend on DSpace 7.6 with this patch and setting a system-wide alert. Works as expected. Anything else I should test?

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @mirkoscherf . I tested this as well, including triggering alerts after editing objects, submitting objects, etc. I could not find any issues. So, this looks good to me too.

@tdonohue tdonohue modified the milestones: 7.6.1, 8.0 Aug 3, 2023
@tdonohue tdonohue merged commit 102310c into DSpace:main Aug 3, 2023
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-2381-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-2381-to-dspace-7_x
git checkout -b backport-2381-to-dspace-7_x
ancref=$(git merge-base 44b197a15a7e855021861db6f0fdca495a207af8 81e6ecc5c427955e3e9fc8c89953335f4654d5be)
git cherry-pick -x $ancref..81e6ecc5c427955e3e9fc8c89953335f4654d5be

@tdonohue
Copy link
Member

tdonohue commented Aug 3, 2023

As the automatic backport above failed, I'll manually cherry-pick this to dspace-7_x branch. PR coming soon...

UPDATE: Manual port created in #2416

@tdonohue tdonohue removed the port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release label Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug code task
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Typo in alert-type
4 participants