Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this endpoint is the right place for statistics reports. Since you use it to POST one event at a time, you would expect to GET events with the same level of detail, and that's not very useful for a report. Reports are usually about a combination of a few aspects of a number of events at the same time. e.g. the most popular items in the repository, where we need to facet the view events on item id.
I envision reports will get a dedicated endpoint e.g.
/api/statistics/reports
that will return data in some json equivalent of a table formatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. That was my mistake to leave the endpoint as is. I will change it.