Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed singular endpoints to their plural version #254

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Renamed singular endpoints to their plural version #254

merged 1 commit into from
Feb 22, 2024

Conversation

alexandrevryghem
Copy link
Member

References

Description

This PR renames the few references in the rest contract where the singular form of the endpoints is still being used

@alexandrevryghem alexandrevryghem self-assigned this Feb 20, 2024
@alexandrevryghem alexandrevryghem mentioned this pull request Feb 20, 2024
Merged
8 tasks
abollini
abollini approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@abollini abollini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok to me. I understand that @tdonohue agree to work on CHANGES.md file in a followup PR where we can note major change over the REST API

@tdonohue tdonohue added the 1 APPROVAL pull request only requires a single approval to merge. label Feb 22, 2024
@tdonohue tdonohue added this to the 8.0 milestone Feb 22, 2024
@tdonohue tdonohue merged commit 80ff179 into DSpace:main Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abollini abollini abollini approved these changes

@tdonohue tdonohue Awaiting requested review from tdonohue

Assignees

@alexandrevryghem alexandrevryghem

Labels
1 APPROVAL pull request only requires a single approval to merge.
Projects
No open projects
DSpace 8.0 Release
Status: ✅ Done
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandrevryghem @abollini @tdonohue