Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a DSpace internal quality assurance source #250

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

abollini
Copy link
Member

Please note that this development has been funded by the University of California - California Digital Library.

This PR adds the endpoints required to implement a "DSpace Users" driven quality assurance source named "DSpace User Corrections". This gives the possibility to create quality assurance event, retrieve quality assurance event created by the current user and delete them.

The DSpace User Corrections manage different types of correction providing future proof extensibility that can be discovered via the proposed new REST API correctiontypes endpoint.

The REST and Angular PRs are following that will use this new endpoint to provide the ability for authorized users to request withdrawal or reinstate of an item managing the request within DSpace instead than rely on email or other external communication.

Please note that

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abollini : Overall this looks good. But, I've noticed that we seem to be missing documentation for at least a few new endpoints created by this feature. See inline below

qualityassuranceevents.md Show resolved Hide resolved
correctiontypes.md Show resolved Hide resolved
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @abollini for the responses. On second look, this all looks good to me.

@tdonohue tdonohue added this to the 8.0 milestone Feb 27, 2024
@tdonohue tdonohue merged commit 73df0d4 into DSpace:main Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority integration: QA Notifications Related to QA (Quality Assurance) notifications from external sources new feature
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants