Require JDK >- 17, bump dependency versions to match DSpace main #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@misilot i think the reload4j idea will work well, i just wanted to offer an alternative that might have a nice side effect of bringing all the other bits and pieces up to date - feel free to try this out and let me know if it works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be an alternative to the problem posed by #5 if there are not constraints on running older versions of Java... I basically tried to align the pom with DSpace main (as at pre-9.0) and enforce JDK17.
I've tried a build but not running it in practice...
This could even be a separate branch rather than a merge to main... or current main could get branched to 1.x or something.