Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance *State/Mode classes with incoming and outgoing StateTransition accessors #455

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

chgio
Copy link
Contributor

@chgio chgio commented Sep 29, 2024

Hello py-capellambse team, and thank you very much for this great project and especially for the amazing contributor experience!

I'm interested in working with StateMachines and the relations within and around them, so I noticed #426 which I'll now stop spamming with mentions. To start from the related StateTransitions, this PR adds:

  • incoming_transitions
  • outgoing_transitions

Please check the commits for the detailed lists of classes impacted, which can also be rolled back to just State.

The PR also adds test cases for both of these new accessors on State, and for InitialPseudoState.outgoing_transitions; I couldn't find a StateMachine with a FinalState to write the test case for FinalState.incoming_transitions but it should be easy to add with the right UUIDs.

Thanks in advance!

Copy link
Member

@Wuestengecko Wuestengecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks!

Register and declare ReferenceSearchingAccessors for StateTransitions
leading into and out of a State:

- incoming_transitions to all *State classes except InitialPseudoState
- outgoing_transitions to all *State classes except FinalState and
  TerminatePseudoState

Refs: DSD-DBS#426
@Wuestengecko Wuestengecko merged commit 8394e9b into DSD-DBS:master Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants