Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RA patch for JNSQ #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RA patch for JNSQ #69

wants to merge 2 commits into from

Conversation

Grimmas
Copy link

@Grimmas Grimmas commented Oct 29, 2021

The stock RA config places DSN dishes in the middle of the ocean when used with JNSQ (Kerbin changes a lot there) so I wrote my own basic config.

This patch adds a few DSN locations along the equator, two on islands east of KSC to support eastward launches and one west of the desert airfield. I've also added two L-band dishes, one in the northern hemisphere and one in the south.

I might add more to this at some point but I plan to start playing JNSQ with this config for now. I've tested the locations (in that the dishes show up as objects on the ground and can be acquired from orbit) but additional testing is welcome.

Adds DSN locations for JNSQ
Copy link
Owner

@DRVeyl DRVeyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Could you make a couple changes?

// author: Grimmas
//

@Kopernicus:FOR[JNSQ]:NEEDS[Kopernicus,JNSQ]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to BEFORE[JNSQ] or AFTER[JNSQ].
Doing FOR[JNSQ] is a bad practice, since it will declare the JNSQ pass as existing! Thus making NEEDS[JNSQ] always true.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping in line with the other patch structures; RSS does this:

@Kopernicus:FOR[RealSolarSystem_Late]:NEEDS[Kopernicus,RealSolarSystem]

So might be best to use:

@Kopernicus:FOR[JNSQ_Late]:NEEDS[Kopernicus,JNSQ]

It should be fine to declare JNSQ_Late since... nothing should be looking for that. If we want to be overly careful, perhaps JNSQ_RealAntennas

Comment on lines 14 to 17
!City2[*TrackingStation],* {}
//!City2[GenericTrackingStation],* {}

City2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix indenting.

Comment on lines 62 to 105
City2
{
name = GenericTrackingStation
objectName = Northern Dish
isKSC = False
commnetStation = True
snapToSurface = True
lat = 50
lon = 20
alt = 0
snapHeightOffset = 0
up = 0.0, 1.0, 0.0
rotation = 0
order = 100
enabled = True
}

City2
{
name = GenericTrackingStation
objectName = Southern Dish
isKSC = False
commnetStation = True
snapToSurface = True
lat = -65
lon = 90
alt = 5
snapHeightOffset = 0
up = 0.0, 1.0, 0.0
rotation = 0
order = 100
enabled = True
}

@City2[*TrackingStation],*
{
commnetStation = True
snapToSurface = True
snapHeightOffset = 0
up = 0.0, 1.0, 0.0
rotation = 0
order = 100
}
@City2[*TrackingStation],*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indenting

}
}
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add newline after final }

requested fixes
@Grimmas
Copy link
Author

Grimmas commented Oct 30, 2021

I've added the changes you requested. The indenting thing is weird. It looked fine in my editor and usually I don't have that issue. I tried with another editor, hopefully it is fixed now.

BTW in the issues tracker there is a much more complete, RO-like JNSQ patch from another user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants