Convert device table location columns to PostGIS geometry datatype #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ommand via the --properties flag. DAO & RestAPI updated to handle PostGIS geometry location column. Removed backoff annotations from DAO, they have not been useful. Changed errors raised by the DAO to be ValueErrors when parameter validation fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GIS apps such as QGIS do not recognise the PostgreSQL point datatype as a valid geometry type.
This PR changes the db container to use a PostGIS image, and converts the location column in the device tables to be of type geometry('point') with SRID 4283 to match up with the SCMN.
This choice may be short-sighted - it is only suitable for Australian users.
A subsequent change could be to parameterise the SRID via an env var or similar.
The webapp, REST API, and DAO code are all updated to suit.
The backoff annotations have also been removed from the DAO. So far in practice they have not been necessary and if the DB falls over, the rest of the system probably doesn't work either due to the fact they're all currently on the same server.