Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a tutorial for bundle adjustment in isis #61

Merged
merged 10 commits into from
May 13, 2024

Conversation

AustinSanders
Copy link
Contributor

@AustinSanders AustinSanders commented May 1, 2024

Adds a bundle adjustment tutorial. Should probably be fact checked, since I'm definitely not an expert in the art of bundle adjustment.

Closes #11 and Closes #51

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@amystamile-usgs
Copy link
Contributor

Might be worth including this information in here:
Jigsaw.pdf

@AustinSanders AustinSanders marked this pull request as ready for review May 3, 2024 20:26
@AustinSanders
Copy link
Contributor Author

Might be worth including this information in here: Jigsaw.pdf

I'm struggling to integrate that information into a 'how-to-guide' -- a lot of it falls into application documentation and concepts. Would it be acceptable to make a bundle adjustment concept doc that includes that info instead?

@amystamile-usgs
Copy link
Contributor

Might be worth including this information in here: Jigsaw.pdf

I'm struggling to integrate that information into a 'how-to-guide' -- a lot of it falls into application documentation and concepts. Would it be acceptable to make a bundle adjustment concept doc that includes that info instead?

Honestly this may be better on the actual jigsaw app docs page.

Copy link
Contributor

@jlaura jlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads more like a high level, general about than a tutorial. If that is the intention 👍. If not, I believe this needs to have a small amount of actual data with described inputs and outputs that one can copy/paste to run.

Then is needs a discussion of the outputs. Right now, someone is going to get a wall of text/numbers and have no idea what they are looking at.

@AustinSanders AustinSanders marked this pull request as draft May 7, 2024 03:27
@AustinSanders AustinSanders marked this pull request as ready for review May 9, 2024 20:01
@jrcain-usgs
Copy link
Contributor

As somewhat of a newbie, I was able to go through the tutorial and get the same result at the end. (I only have a basic understanding of the whole bundle-adjustment process, may read more into jigsaw docs later as suggested at the top.) The data added made it much easier to follow along.

@AustinSanders AustinSanders merged commit 5953c24 into DOI-USGS:main May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document USGSCSM parameters jigsaw tutorial
4 participants