Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes MSI IsisLabelNaifSpice driver and adds tests #598

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

acpaquette
Copy link
Collaborator

This PR has a small center_ephemeris_time fix similar to the fix in #592 where the time was being computed slightly different to how ISIS computes the center.

This PR also adds tests for MSI and enables the driver based on the ephemeris comparison bellow:
Screenshot 2024-03-04 at 2 33 23 PM

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.49%. Comparing base (bc50c79) to head (7395d19).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
ale/drivers/msi_drivers.py 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #598      +/-   ##
==========================================
- Coverage   15.71%   15.49%   -0.23%     
==========================================
  Files          57       57              
  Lines        6326     6416      +90     
==========================================
  Hits          994      994              
- Misses       5332     5422      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kelvinrr Kelvinrr merged commit 1e3fdea into DOI-USGS:main Mar 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants