Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled juno cam ISISLabelNaifSpice driver #597

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

acpaquette
Copy link
Collaborator

Enables the juno JunoCAM ISISLabelNaifSpice driver for use in ISIS to get spice data. See the attached image for verification of ephemeris data:

Screenshot 2024-03-04 at 12 48 56 PM

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.81%. Comparing base (4e89736) to head (4caffaa).
Report is 1 commits behind head on main.

❗ Current head 4caffaa differs from pull request most recent head 82aa3c0. Consider uploading reports for the commit 82aa3c0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #597   +/-   ##
=======================================
  Coverage   14.81%   14.81%           
=======================================
  Files          59       59           
  Lines        6709     6709           
=======================================
  Hits          994      994           
  Misses       5715     5715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AustinSanders
AustinSanders previously approved these changes Mar 5, 2024
@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Mar 5, 2024

was there nothing wrong with the driver?

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Mar 5, 2024

Also needs a changelog

@acpaquette
Copy link
Collaborator Author

@Kelvinrr Same reason as #596

CHANGELOG.md Outdated Show resolved Hide resolved
@acpaquette acpaquette merged commit e53abf4 into DOI-USGS:main Mar 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants