Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users were dealing with weird interactions between ALE and ISIS w.r.t. ISIS preference files. If users had old preference files there paths would expand as such:
$lro/path/to/lro/kernel
$ISIS3DATA/lro/path/to/lro/kernel
$ISISDATA/lro/path/to/lro/kernel
Then stop there since we only expected paths to contain one ISIS preference defined variable and one os.environ variable. This prevents ALE from being able to get spice data for anything since the paths didn't fully unwrap.
This PR changes the expandvar function to expand all IsisPreference variables and env variables. If we cannot expand a variable the function now errors out.