Skip to content

Commit

Permalink
passing tests (#618)
Browse files Browse the repository at this point in the history
* passing tests

* removed upload coverage since we dont even pay attention to it anyways right now
  • Loading branch information
Kelvinrr authored Sep 17, 2024
1 parent 64f8c6a commit b644fd5
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 8 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/ci_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ jobs:
run: |
cd build
ctest -VV
- name: Upload Coverage
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
verbose: true
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.9'
# - name: Upload Coverage
# uses: codecov/codecov-action@v1
# with:
# token: ${{ secrets.CODECOV_TOKEN }}
# fail_ci_if_error: true
# verbose: true
# if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.9'

Build-Docs:
runs-on: ubuntu-latest
Expand Down
14 changes: 13 additions & 1 deletion ale/drivers/apollo_drivers.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def detector_center_sample(self):
class ApolloPanIsisLabelIsisSpiceDriver(LineScanner, IsisLabel, IsisSpice, NoDistortion, Driver):

@property
def instrument_name(self):
def instrument_id(self):
"""
The name of the instrument.
Expand All @@ -158,6 +158,18 @@ def instrument_name(self):
return id_lookup[super().instrument_id]


@property
def instrument_name(self):
"""
The name of the instrument.
Returns
-------
str
The short text name for the instrument
"""
return "APOLLO PANORAMIC CAMERA"

@property
def sensor_model_version(self):
"""
Expand Down

0 comments on commit b644fd5

Please sign in to comment.