Skip to content

Commit

Permalink
Merge pull request #5 from DNXLabs/feature/checkov
Browse files Browse the repository at this point in the history
Feature/checkov
  • Loading branch information
alexandrealvao authored Jun 15, 2023
2 parents f93f6a1 + 26b6933 commit 399f24a
Show file tree
Hide file tree
Showing 6 changed files with 34 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: Generate terraform docs

on: [pull_request]

permissions: read-all

jobs:
docs:
runs-on: ubuntu-latest
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ on:
branches:
- master

permissions: read-all


jobs:
docs:
runs-on: ubuntu-latest
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ name: Lint

on: [push]

permissions: read-all

jobs:
tflint:
name: Lint
Expand Down
19 changes: 19 additions & 0 deletions .github/workflows/scan.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Scan

on: [push]

permissions: read-all

jobs:
scan:
runs-on: ubuntu-latest
steps:
- name: Checkout repo
uses: actions/checkout@v3
- name: Run Checkov action
id: checkov
uses: bridgecrewio/checkov-action@v12
with:
directory: .
framework: terraform
skip_check: CKV2_AWS_5
6 changes: 6 additions & 0 deletions _variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,10 @@ variable "app_network_access_type" {
type = string
default = "PublicInternetOnly"
description = "Specifies the VPC used for non-EFS traffic. The default value is PublicInternetOnly. Valid values are PublicInternetOnly and VpcOnly."
}

variable "kms_key_id" {
type = string
default = null
description = "The AWS KMS customer managed CMK used to encrypt the EFS volume attached to the domain."
}
1 change: 1 addition & 0 deletions sagemaker_domain.tf
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ resource "aws_sagemaker_domain" "domain" {
vpc_id = var.sagemaker_domain_vpc_id
subnet_ids = var.sagemaker_domain_subnet_ids
app_network_access_type = var.app_network_access_type
kms_key_id = var.kms_key_id

default_user_settings {
security_groups = [aws_security_group.sagemakerstudio.id]
Expand Down

0 comments on commit 399f24a

Please sign in to comment.