fix some comments

protocol/dubbo/example/new/client/main.go

@@ -22,77 +22,15 @@ import (
 )
 
 import (
- gxset "github.com/dubbogo/gost/container/set"
  "github.com/dubbogo/gost/log/logger"
 )
 
 import (
  "dubbo.apache.org/dubbo-go/v3/client"
- "dubbo.apache.org/dubbo-go/v3/common"
- "dubbo.apache.org/dubbo-go/v3/common/extension"
- "dubbo.apache.org/dubbo-go/v3/config"
- "dubbo.apache.org/dubbo-go/v3/config_center"
- "dubbo.apache.org/dubbo-go/v3/config_center/parser"
  _ "dubbo.apache.org/dubbo-go/v3/imports"
 )
 
-type noOpConf struct {
-}
-
-func (n *noOpConf) Parser() parser.ConfigurationParser {
- return nil
-}
-
-func (n *noOpConf) SetParser(parser parser.ConfigurationParser) {
- return
-}
-
-func (n *noOpConf) AddListener(s string, listener config_center.ConfigurationListener, option ...config_center.Option) {
- return
-}
-
-func (n *noOpConf) RemoveListener(s string, listener config_center.ConfigurationListener, option ...config_center.Option) {
- return
-}
-
-func (n *noOpConf) GetProperties(s string, option ...config_center.Option) (string, error) {
- return "", nil
-}
-
-func (n *noOpConf) GetRule(s string, option ...config_center.Option) (string, error) {
- return "", nil
-}
-
-func (n *noOpConf) GetInternalProperty(s string, option ...config_center.Option) (string, error) {
- return "", nil
-}
-
-func (n *noOpConf) PublishConfig(s string, s2 string, s3 string) error {
- return nil
-}
-
-func (n *noOpConf) RemoveConfig(s string, s2 string) error {
- return nil
-}
-
-func (n *noOpConf) GetConfigKeysByGroup(group string) (*gxset.HashSet, error) {
- return nil, nil
-}
-
-type noOpConfFactory struct{}
-
-// GetDynamicConfiguration Get Configuration with URL
-func (f *noOpConfFactory) GetDynamicConfiguration(url *common.URL) (config_center.DynamicConfiguration, error) {
- return &noOpConf{}, nil
-}
-
 func main() {
- extension.SetConfigCenterFactory("no-op", func() config_center.DynamicConfigurationFactory {
- return &noOpConfFactory{}
- })
- if err := config.Load(); err != nil {
- panic(err)
- }
  cli, err := client.NewClient(
  client.WithClientProtocolDubbo(),
  )

protocol/triple/health/health_test.go

@@ -35,6 +35,8 @@ import (
 
 const testService = "testService"
 
+// If there is a conflict between the healthCheck of Dubbo and the healthCheck of gRPC, an error will occur.
+
 func TestSetServingStatus(t *testing.T) {
  s := NewServer()
  s.SetServingStatus(testService, healthpb.HealthCheckResponse_SERVING)

protocol/triple/server.go

@@ -117,28 +117,6 @@ func (s *Server) Start(invoker protocol.Invoker, info *server.ServiceInfo) {
  logger.Errorf("server serve failed with err: %v", runErr)
  }
  }()
-
- //go func() {
- // mux := s.handler
- // if info != nil {
- // handleServiceWithInfo(invoker, info, mux, hanOpts...)
- // s.saveServiceInfo(info)
- // } else {
- // compatHandleService(URL, mux)
- // }
- // // todo: figure it out this process
- // reflection.Register(s)
- // // todo: without tls
- // if cfg == nil {
- // srv.Handler = h2c.NewHandler(mux, &http2.Server{})
- // } else {
- // srv.Handler = mux
- // }
- //
- // if err = srv.ListenAndServe(); err != nil {
- // logger.Errorf("server serve failed with err: %v", err)
- // }
- //}()
 }
 
 // RefreshService refreshes Triple Service
@@ -258,7 +236,6 @@ func (s *Server) compatHandleService(url *common.URL, opts ...tri.HandlerOption)
 
 func (s *Server) compatRegisterHandler(svc dubbo3.Dubbo3GrpcService, opts ...tri.HandlerOption) {
  desc := svc.XXX_ServiceDesc()
- //basePath := desc.ServiceName
  // init unary handlers
  for _, method := range desc.Methods {
  // please refer to protocol/triple/internal/proto/triple_gen/greettriple for procedure examples

protocol/triple/triple_test.go

@@ -135,7 +135,7 @@ func runOldTripleServer(interfaceName string, group string, version string, addr
  SetProvider(
  config.NewProviderConfigBuilder().
  AddService(common.GetReference(svc), config.NewServiceConfigBuilder().
- SetInterface(desc.ServiceName).
+ SetInterface(interfaceName).
  SetGroup(group).
  SetVersion(version).
  Build()).