Enforce mandatory CA in SET_CERTIFICATE #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-bellock
force-pushed
the
fix-2731
branch
from
5cab1dc
to
1688e30
Compare
jyao1
reviewed
Sep 25, 2024
| @@ -245,7 +260,8 @@ libspdm_return_t libspdm_get_response_set_certificate(libspdm_context_t *spdm_co | |||
|
|
|||
| #if LIBSPDM_CERT_PARSE_SUPPORT | |||
| /*check the cert_chain*/ | |||
| result = libspdm_set_cert_verify_certchain(cert_chain, cert_chain_size, | |||
| result = libspdm_set_cert_verify_certchain(spdm_version, | |||
| cert_chain, cert_chain_size, | |||
| spdm_context->connection_info.algorithm.base_asym_algo, | |||
| spdm_context->connection_info.algorithm.base_hash_algo, | |||
| is_device_cert_model); | |||
There was a problem hiding this comment.
The last parameter is changed to uint8_t cert_model.
There was a problem hiding this comment.
Wow. Thank you for type checking when the C compiler could not. 😆
jyao1
reviewed
Sep 25, 2024
Comment on lines
+48
to
+56
| if (!libspdm_x509_set_cert_certificate_check(leaf_cert_buffer, leaf_cert_buffer_size, | ||
| base_asym_algo, base_hash_algo, | ||
| false, is_device_cert_model)) { | ||
| return false; | ||
| } | ||
| } else { | ||
| if (!libspdm_x509_set_cert_certificate_check_ex(leaf_cert_buffer, leaf_cert_buffer_size, | ||
| base_asym_algo, base_hash_algo, | ||
| false, cert_model)) { |
There was a problem hiding this comment.
It looks weird to only support 1.3 in ex version and only support 1.2 in non-ex version.
I feel it will be easily mis-used, if it is designed in such way.
But I don't have good idea now. Need to think through.
jyao1
reviewed
Sep 25, 2024
| @@ -917,7 +917,7 @@ bool libspdm_x509_certificate_check_ex(const uint8_t *cert, size_t cert_size, | |||
| uint32_t base_asym_algo, uint32_t base_hash_algo, | |||
| bool is_requester, uint8_t cert_model); | |||
| /** | |||
| * Certificate Check for SPDM leaf cert when set_cert. | |||
| * Certificate Check for SPDM leaf cert when set_cert. It is used for SPDM 1.2. | |||
There was a problem hiding this comment.
We had better add some reason for the ex/non-ex version difference.
For example, the basic constrain is not checked in 1.2, but will be checked in 1.3.
steven-bellock
force-pushed
the
fix-2731
branch
2 times, most recently
from
7684a72
to
dfa9d25
Compare
Fix DMTF#2731. Signed-off-by: Steven Bellock <[email protected]>
steven-bellock
force-pushed
the
fix-2731
branch
from
dfa9d25
to
0e174bf
Compare
jyao1
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2731.
Signed-off-by: Steven Bellock [email protected]