-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Set_cert key_pair_id parameter to sync spdm 1.3 #2613
Conversation
3fc0e5e
to
94dd5d2
Compare
Is this a full patch? |
c50e48c
to
b231ae9
Compare
Thanks. I have updated the patch to make it completely. |
/*write KeyPairID.*/ | ||
spdm_context->local_context.local_key_pair_id[slot_id] = key_pair_id; | ||
} else { | ||
if (spdm_request->header.param2 != 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this check should only in 1.3+.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have deleted the check in 1.2.
b231ae9
to
cf6a10f
Compare
key_pair_id = spdm_request->header.param2; | ||
/*write KeyPairID.*/ | ||
spdm_context->local_context.local_key_pair_id[slot_id] = key_pair_id; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to check version >= 1.3 && multi_key_conn_rsp == false.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have added the check.
(spdm_context->connection_info.multi_key_conn_rsp)) { | ||
key_pair_id = spdm_request->header.param2; | ||
/*write KeyPairID.*/ | ||
spdm_context->local_context.local_key_pair_id[slot_id] = key_pair_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to add comment: key_pair_id / slot_id check will be done in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have added the comment.
ab3220d
to
99b4331
Compare
key_pair_id = spdm_request->header.param2; | ||
if (spdm_context->connection_info.multi_key_conn_rsp) { | ||
/*write KeyPairID. And key_pair_id/slot_id check will be done in the future.*/ | ||
spdm_context->local_context.local_key_pair_id[slot_id] = key_pair_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libspdm currently does not update the local context for SET_CERTIFICATE
. That's left to the Integrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. It should just check if key_pair_id is 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I have updated the code.
9be5608
to
f95ec3a
Compare
Ref the issue: DMTF#2292 Signed-off-by: Wenxing Hou <[email protected]>
Signed-off-by: Wenxing Hou <[email protected]>
f95ec3a
to
f4d7fe1
Compare
Have you validated spdm-emu? |
Fix: #2292