Refactor contest join checks #1886
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Riolku
force-pushed
the
refactor-join-check
branch
from
9c79d6a to
dba4438
Compare
Codecov ReportBase: 46.46% // Head: 46.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1886 +/- ##
==========================================
+ Coverage 46.46% 46.49% +0.03%
==========================================
Files 236 236
Lines 13114 13118 +4
==========================================
+ Hits 6093 6099 +6
+ Misses 7021 7019 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Ninjaclasher since you suggested this can I get your review? |
Riolku
force-pushed
the
refactor-join-check
branch
3 times, most recently
from
85d0f1b to
9c2b2a8
Compare
|
As mentioned in the comment under Ninjaclasher's review, it was noted that there's a regression, introduced in 8b04126, that forced people to enter access codes when spectating. It has been fixed here. Some useless code also deleted, as requested. |
Ninjaclasher
approved these changes
Mar 9, 2022
Riolku
force-pushed
the
refactor-join-check
branch
from
9c2b2a8 to
f9d811e
Compare
Riolku
force-pushed
the
refactor-join-check
branch
from
f9d811e to
3ae3d44
Compare
int-y1
suggested changes
May 23, 2022
Riolku
force-pushed
the
refactor-join-check
branch
from
3ae3d44 to
ac0adab
Compare
int-y1
reviewed
May 23, 2022
Riolku
force-pushed
the
refactor-join-check
branch
from
ac0adab to
1d74d52
Compare
Xyene
reviewed
Oct 28, 2022
Riolku
force-pushed
the
refactor-join-check
branch
from
1d74d52 to
6533c2a
Compare
As suggested, merge the access checks into one. Some tests had to be changed, because the old checks didn't check the dates.
Riolku
force-pushed
the
refactor-join-check
branch
from
6533c2a to
4dab995
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested, merge the access checks into one. Some tests had to be changed, because the old checks didn't check the dates.