Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize weights_only during load to allow loading of unusual models #1899

Closed
wants to merge 8 commits into from

Conversation

markscsmith
Copy link
Contributor

When using stable_baselines3, it is possible to specify a learning_rate_schedule that is a function rather than a static number. If this function contains numpy scalars (e.g.: np.pi) these scalars will cause the model to fail to load with weights_only=True because the numpy scalars are not a supported type.

Description

The primary change is a "weights_only" parameter for the load function, allowing the user to change the weights_only parameter as needed when loading models of this type.

Motivation and Context

This is to address an edge case around learning_rate_schedule being a function and also using data types that are not marked safe as part of torch.load

Related to enhancement #1852

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the SB3-Contrib repository (if necessary)
  • I have opened an associated PR on the RL-Zoo3 repository (if necessary)
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

@markscsmith
Copy link
Contributor Author

I wasn't sure if this should be a new issue since I referenced the existing one, but if you'd prefer I open that instead of using the existing enhancement I'm happy to do that instead! Thanks again!

This reverts commit 6c24ad2, reversing
changes made to 5623d98.
@markscsmith
Copy link
Contributor Author

Opening different PR with from branch to allow choice of feature to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant