-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TD3/DDPG/DQN defaults for consistency #1785
Conversation
Small update, it seems that we should keep |
I would like to also see SAC tested with |
Here you go (3 seeds only for now), there seems to be a small improvement for HC and Ant but need more seeds for confirmation. Influence of the neural network size for TD3: Not much to say, small impact only. |
* Update TD3/DDPG/DQN defaults for consistency * Update changelog
Description
closes #1769
closes #1562
EDIT: WIP report is here: https://wandb.ai/openrlbenchmark/sbx/reports/SBX-TD3-RL-Zoo-v2-3-0a0-vs-SB3-TD3-RL-Zoo-2-2-1---Vmlldzo2MjUyNTQx
Note: I didn't change the default network architecture because it would break all pre-trained models where
net_arch
was not specified properly.TODO:
Motivation and Context
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line