Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.8, add python 3.12 support #477

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Drop python 3.8, add python 3.12 support #477

merged 4 commits into from
Nov 19, 2024

Conversation

araffin
Copy link
Member

@araffin araffin commented Nov 18, 2024

Description

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin
Copy link
Member Author

araffin commented Nov 18, 2024

Currently blocked by bulletphysics/bullet3#4649, pybullet needs to be re-compiled with Numpy>=2.0

cc @erwincoumans (hopefully it is only a matter of triggering a build, if not, please let us know and I'm sure some people will be happy to provide PRs that solve the issues)

@araffin
Copy link
Member Author

araffin commented Nov 19, 2024

Solved it by downgrading numpy and adding a note for now until bulletphysics/bullet3#4649 is resolved.

@araffin araffin merged commit 633954f into master Nov 19, 2024
8 checks passed
@araffin araffin deleted the chore/update-deps branch November 19, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant