Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated huggingface_hub.Repository by HfApi #465

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

qgallouedec
Copy link
Collaborator

@qgallouedec qgallouedec commented Jul 23, 2024

Description

Copy of #462

closes #463

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@qgallouedec qgallouedec changed the title Replace deprecated 'Repository' by HfApi Replace deprecated huggingface_hub.Repository by HfApi Jul 23, 2024
@araffin
Copy link
Member

araffin commented Jul 23, 2024

For the failure on CI: Stable-Baselines-Team/stable-baselines3-contrib@03db09e

and for ValueError: loaded state dict contains a parameter group that doesn't match the size of optimizer's group

I hope it is not DLR-RM/stable-baselines3#1975

Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

@araffin araffin merged commit 726e2f1 into master Aug 6, 2024
8 checks passed
@araffin araffin deleted the drop_hf_hub_repository branch August 6, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Deprectated Repository with HfApi
2 participants