Update CI workflow, skip mypy for 3.8 (#466)

* update CI * submodules:True * update ci --------- Co-authored-by: Quentin Gallouédec <[email protected]>
DLR-RM · Jul 26, 2024 · 9846160 · 9846160
1 parent e1a40be
commit 9846160
Show file tree

Hide file tree

Showing 2 changed files with 68 additions and 64 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -5,9 +5,9 @@ name: CI
 
 on:
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
 
 jobs:
   build:
@@ -20,43 +20,46 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.8", "3.9", "3.10", "3.11"]
+
     steps:
-    - uses: actions/checkout@v2
-      with:
-        submodules: true
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v2
-      with:
-        python-version: ${{ matrix.python-version }}
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
 
-        # Install Atari Roms
-        pip install autorom
-        wget https://gist.githubusercontent.com/jjshoots/61b22aefce4456920ba99f2c36906eda/raw/00046ac3403768bfe45857610a3d333b8e35e026/Roms.tar.gz.b64
-        base64 Roms.tar.gz.b64 --decode &> Roms.tar.gz
-        AutoROM --accept-license --source-file Roms.tar.gz
+          # Install Atari Roms
+          pip install autorom
+          wget https://gist.githubusercontent.com/jjshoots/61b22aefce4456920ba99f2c36906eda/raw/00046ac3403768bfe45857610a3d333b8e35e026/Roms.tar.gz.b64
+          base64 Roms.tar.gz.b64 --decode &> Roms.tar.gz
+          AutoROM --accept-license --source-file Roms.tar.gz
 
-        # cpu version of pytorch - faster to download
-        pip install torch==2.3.1 --index-url https://download.pytorch.org/whl/cpu
+          # cpu version of pytorch - faster to download
+          pip install torch==2.3.1 --index-url https://download.pytorch.org/whl/cpu
 
-        pip install -r requirements.txt
-        # Use headless version
-        pip install opencv-python-headless
-        pip install -e .[plots,tests]
-    - name: Lint with ruff
-      run: |
-        make lint
-    - name: Check codestyle
-      run: |
-        make check-codestyle
-    - name: Build doc
-      run: |
-        make doc
-    - name: Type check
-      run: |
-        make type
-    - name: Test with pytest
-      run: |
-        make pytest
+          pip install -r requirements.txt
+          # Use headless version
+          pip install opencv-python-headless
+          pip install -e .[plots,tests]
+      - name: Lint with ruff
+        run: |
+          make lint
+      - name: Check codestyle
+        run: |
+          make check-codestyle
+      - name: Build the doc
+        run: |
+          make doc
+      - name: Type check
+        run: |
+          make type
+        # Do not run for python 3.8 (mypy internal error)
+        if: matrix.python-version != '3.8'
+      - name: Test with pytest
+        run: |
+          make pytest
diff --git a/.github/workflows/trained_agents.yml b/.github/workflows/trained_agents.yml
@@ -5,9 +5,9 @@ name: Check-Trained-Agents
 
 on:
   push:
-    branches: [ master ]
+    branches: [master]
   pull_request:
-    branches: [ master ]
+    branches: [master]
 
 jobs:
   build:
@@ -21,30 +21,31 @@ jobs:
     strategy:
       matrix:
         python-version: ["3.8", "3.9", "3.10", "3.11"]
+
     steps:
-    - uses: actions/checkout@v3
-      with:
-        submodules: true
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v4
-      with:
-        python-version: ${{ matrix.python-version }}
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
+      - uses: actions/checkout@v3
+        with:
+          submodules: true
+      - name: Set up Python ${{ matrix.python-version }}
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
 
-        # Install Atari Roms
-        pip install autorom
-        wget https://gist.githubusercontent.com/jjshoots/61b22aefce4456920ba99f2c36906eda/raw/00046ac3403768bfe45857610a3d333b8e35e026/Roms.tar.gz.b64
-        base64 Roms.tar.gz.b64 --decode &> Roms.tar.gz
-        AutoROM --accept-license --source-file Roms.tar.gz
+          # Install Atari Roms
+          pip install autorom
+          wget https://gist.githubusercontent.com/jjshoots/61b22aefce4456920ba99f2c36906eda/raw/00046ac3403768bfe45857610a3d333b8e35e026/Roms.tar.gz.b64
+          base64 Roms.tar.gz.b64 --decode &> Roms.tar.gz
+          AutoROM --accept-license --source-file Roms.tar.gz
 
-        # cpu version of pytorch - faster to download
-        pip install torch==2.3.1 --index-url https://download.pytorch.org/whl/cpu
-        pip install -r requirements.txt
-        # Use headless version
-        pip install opencv-python-headless
-        pip install -e .[plots,tests]
-    - name: Check trained agents
-      run: |
-        make check-trained-agents
+          # cpu version of pytorch - faster to download
+          pip install torch==2.3.1 --index-url https://download.pytorch.org/whl/cpu
+          pip install -r requirements.txt
+          # Use headless version
+          pip install opencv-python-headless
+          pip install -e .[plots,tests]
+      - name: Check trained agents
+        run: |
+          make check-trained-agents