Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Threads inside of Partitions instead of Processes #107

Merged
merged 9 commits into from
Feb 29, 2024

Conversation

sevenautumns
Copy link
Collaborator

No description provided.

@sevenautumns sevenautumns force-pushed the dev/threaded_partitions branch 4 times, most recently from 4cb341e to 63bdfc3 Compare February 22, 2024 08:26
@florianhartung
Copy link
Collaborator

Note: this should also close #85

@sevenautumns sevenautumns linked an issue Feb 22, 2024 that may be closed by this pull request
@sevenautumns sevenautumns marked this pull request as ready for review February 22, 2024 13:11
@dadada dadada self-requested a review February 22, 2024 15:53
hypervisor/src/hypervisor/partition.rs Outdated Show resolved Hide resolved
partition/Cargo.toml Outdated Show resolved Hide resolved
@@ -99,14 +79,6 @@ pub(crate) static UDP_IO_RX: Lazy<IoReceiver<UdpSocket>> =
pub(crate) static TCP_IO_RX: Lazy<IoReceiver<TcpStream>> =
Lazy::new(|| unsafe { IoReceiver::<TcpStream>::from_raw_fd(CONSTANTS.io_fd) });

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Informational: It is a shame the socket needs to be connected in the hypervisor. We may think about using something like slirp for more flexible networking.

@sevenautumns sevenautumns force-pushed the dev/threaded_partitions branch 2 times, most recently from e1f5000 to 02c031e Compare February 27, 2024 12:03
sevenautumns and others added 5 commits February 27, 2024 13:44
Inside of partitions threads are used for "processes" instead of processes.
This means that arinc "processes" now share an address space
Replace `Ordering::Relaxed` with `Ordering::SeqCst` as a relaxed ordering may have unexpected behaviour. Also, the performance hit should not be significant.
@dadada dadada merged commit 9dc8d1e into main Feb 29, 2024
10 checks passed
@sevenautumns sevenautumns deleted the dev/threaded_partitions branch February 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Processes are not ARINC compliant
3 participants