Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Protobuf definitions to the root. #74

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

saschadoemer
Copy link
Member

No description provided.

@oliverrahner
Copy link
Member

oliverrahner commented Apr 11, 2024

As this repository only exists for the proto files, shouldn't they be placed even more prominently than in a dot-directory? Maybe just /proto?
And shouldn't we remove the generated artifacts for .NET and Java completely and integrate them into the respective SDK repostiories? Even if not, we should not keep the proto files in multiple places in this repo.

@saschadoemer
Copy link
Member Author

@oliverrahner Fine for me, changes pushed.

@oliverrahner oliverrahner merged commit 399532d into main Apr 11, 2024
@oliverrahner oliverrahner deleted the feature/add-protobuf-definitions-to-root-folder branch April 11, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants