Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for replica truncate tests #476

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

korydraughn
Copy link
Collaborator

These adjustments pass against iRODS 4.3.3 and 4.3.2.

@trel
Copy link
Member

trel commented Aug 27, 2024

nothing jumped out at me - seems good.

Copy link

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same. # it.

iRODS 4.3.2's implementation of rx_replica_truncate contained a bug that
caused it not return JSON as often as it should. The details of the
issue can be found here:

    irods/irods#7918

This commit adjusts the tests so that they work with iRODS 4.3.2 and
iRODS 4.3.3.
@korydraughn
Copy link
Collaborator Author

#'d

@alanking
Copy link

@trel or @korydraughn must merge because I do not have merge powers here.

@korydraughn
Copy link
Collaborator Author

Merging.

@korydraughn korydraughn merged commit 597d2e5 into DICE-UNC:master Aug 27, 2024
1 of 2 checks passed
@korydraughn korydraughn deleted the replica_truncate.m branch August 27, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants