-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dicom importer should modify the imported pixel data if DICOM tags specify this #10
Comments
Just on technical aspect to this. If we apply these during import, we can actually loose data when the voxel type that we write images as does not support a good enough resolution of the rescaled voxel value space. Example:
If we pick an int datatype as target type, then we will loose a bunch of rounded off values that happen during the application of the slope/intercept. Converting everything to float is not a solution either, because some use the integer values to distinguish between classes of data, which does not translate well to floating point values. I personally, do not like the Rescale-values in DICOM as well because it tends to complicate the interpretation of voxel data quite abit, but they are 100% supported in ITK, and if we pre-apply this, we need to be sure that the consequence, which is potential loss of data, is acceptable to us. |
The RescaleSlope and Intercept modifiers have been being applied for the past year (comic/grand-challenge.org#1175). However, if they are applied then we switch to float, otherwise shorts are used covering the data class use case (comic/grand-challenge.org#1244). |
See comic/grand-challenge.org#1140
The text was updated successfully, but these errors were encountered: