Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
parseDomain
pushes the domain from left to right onto the list, we would end up with this list for the domainsubdomain.dfinity.com
(if it would have been implemented correctly, the way it's implemented now thecom
is missing):In the previous code with
List.last<Text>(parsedDomain)
we would assign?subdomain
tosubdomain
inside the first iteration of the while-loop. We would then ask Root-server
forsubdomain
. Instead we should ask root forcom
which is the head of the list.Additionally we would have then called
List.drop<Text>(parsedDomain, counter)
which would have dropped the first 2 elements in our list, leaving us with nothing butThe proposed changes should fix this.