Combine stacks of coins, make combine work in adventure mode #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the now wrong inventory due to item removals)
Ozzatron
suggested changes
Jul 16, 2024
Comment on lines
+826
to
827
| if not dfhack.isMapLoaded() then | ||
| qerror('combine needs a loaded fortress map to work') |
There was a problem hiding this comment.
Using combine from the main menu now gives a disingenuous error message, because it works in adventure mode. Perhaps change this to combine can only be used in-game.
Comment on lines
+704
to
+706
| if dfhack.world.isAdventureMode() and df.global.game.main_interface.adventure.inventory.open then | ||
| -- refresh the inventory to prevent stale item references | ||
| df.global.game.main_interface.adventure.inventory.open = false |
There was a problem hiding this comment.
The user should be notified at least in command console output if their inventory was closed automatically to prevent bugs. Running a tool that does not ostensibly claim it will manipulate UI and having it, surprisingly, manipulate UI, can be a distressing and disorienting experience for users.
can you synthesize this with sent keystrokes? |
myk002
reviewed
Jul 19, 2024
| @@ -792,6 +808,8 @@ local function parse_commandline(opts, args) | |||
| opts.all=get_stockpile_all() | |||
| elseif positionals[1] == 'here' then | |||
| opts.here=get_stockpile_here() | |||
| elseif positionals[1] == 'item' then | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow combine to work in adventure mode and also combine stacks of coins
Note that it's safer to use the (z) -> Items tab to combine stacks currently, as doing so from the (i)nventory will not update the interface to reflect the change until you quit out of the inventory and come back. Need to figure out how to resolve that.