-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makeown-plus #1212
base: master
Are you sure you want to change the base?
Makeown-plus #1212
Conversation
…ns (for now, added THIEF for goblin snatchers)
makeown.lua
Outdated
@@ -215,6 +262,8 @@ function make_own(unit) | |||
else | |||
unit.flags1.tame = true | |||
unit.training_level = df.animal_training_level.Domesticated | |||
-- No more "vengeful" spam when civilizing Giants! | |||
unit.enemy.caste_flags.LARGE_PREDATOR = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this "stick"? I thought unit.enemy.caste_flags
gets overwritten with actual race caste flags (plus syndrome flags) periodically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yah it doesn't stick, might as well remove it
also needs changelog entry |
you can set vscode to remove trailing spaces on save. That might help you pass the pre-commit.ci check with more consistency. |
makeown.lua
Outdated
end | ||
|
||
-- Also used by the script fix/loyaltycascade | ||
function fixUnitEnemyStatus(unit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"fix" is subjective. I think this should be named after what it actually does: clearUnitEnemyStatus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the changelog
edit: also please fix pre-commit.ci warnings
@@ -48,6 +48,7 @@ Template for new versions: | |||
- `gui/pathable`: new "Depot" mode that shows whether wagons can path to your trade depot | |||
- `advtools`: automatically add a conversation option to "ask whereabouts of" for all your relationships (before, you could only ask whereabouts of people involved in rumors) | |||
- `gui/design`: all-new visually-driven UI for much improved usability | |||
- `makeown`: goblin snatchers and giants can now be makeown-ed more reliably |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to get moved to changelog for current version. also, should likely go in Fixes
, and say something like "Fix enemy creatures continuing to be hostile after makeown
"
Able to make snatchers your own now
Able to make giants your own to an extent (though their Large Predator caste flag gets in the way)