Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

51.01-beta26 #810

Merged
merged 1 commit into from
Nov 28, 2024
Merged

51.01-beta26 #810

merged 1 commit into from
Nov 28, 2024

Conversation

quietust
Copy link
Member

@quietust quietust commented Nov 27, 2024

Hopefully I didn't make too many mistakes

Copy link
Contributor

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
adventure_log_event_type linux64 0 4 +4
adventure_log_event_type windows64 0 4 +4
adventure_log_eventst linux64 0 232 +232
adventure_log_eventst windows64 0 232 +232
adventure_log_mode linux64 0 2 +2
adventure_log_mode windows64 0 2 +2
adventurest linux64 38600 38632 +32
adventurest windows64 38584 38616 +32
agreement_details_data_offer_service linux64 0 12 +12
agreement_details_data_offer_service windows64 0 12 +12
agreement_details_data_retrieve_artifact linux64 0 20 +20
agreement_details_data_retrieve_artifact windows64 0 20 +20
agreement_entryst linux64 0 168 +168
agreement_entryst windows64 0 168 +168
announcement_infost linux64 64 72 +8
announcement_infost windows64 64 72 +8
artifact_entryst linux64 0 184 +184
artifact_entryst windows64 0 184 +184
bestiary_entryst linux64 0 104 +104
bestiary_entryst windows64 0 104 +104
creature_interaction linux64 824 0 -824
creature_interaction windows64 824 0 -824
creature_knowledgest linux64 0 88 +88
creature_knowledgest windows64 0 88 +88
creature_raw_graphics linux64 88240 88256 +16
creature_raw_graphics windows64 88240 88256 +16
entity_entryst linux64 0 136 +136
entity_entryst windows64 0 136 +136
gamest linux64 51072 51640 +568
gamest windows64 50264 50832 +568
graphic linux64 265672 278472 +12800
graphic windows64 264848 277648 +12800
histfig_entryst linux64 0 144 +144
histfig_entryst windows64 0 144 +144
init linux64 29136 29144 +8
init windows64 15696 15704 +8
init_media linux64 40 48 +8
init_media windows64 40 48 +8
interaction_informationst linux64 0 824 +824
interaction_informationst windows64 0 824 +824
interaction_source_item_powerst linux64 0 1064 +1064
interaction_source_item_powerst windows64 0 1064 +1064
interaction_source_mythicalst linux64 0 216 +216
interaction_source_mythicalst windows64 0 216 +216
interface_setst linux64 41592 45784 +4192
interface_setst windows64 41592 45784 +4192
item_magicness linux64 12 0 -12
item_magicness windows64 12 0 -12
item_magicness_type linux64 4 0 -4
item_magicness_type windows64 4 0 -4
item_powerst linux64 0 12 +12
item_powerst windows64 0 12 +12
items_other linux64 3192 3216 +24
items_other windows64 3192 3216 +24
main_interface linux64 46304 46872 +568
main_interface windows64 45504 46072 +568
site_entryst linux64 0 136 +136
site_entryst windows64 0 136 +136
subregion_entryst linux64 0 128 +128
subregion_entryst windows64 0 128 +128
viewscreen_adventure_logst linux64 0 1576 +1576
viewscreen_adventure_logst windows64 0 1544 +1544
viewscreen_setupadventurest linux64 880 888 +8
viewscreen_setupadventurest windows64 848 856 +8
world linux64 2551552 2551664 +112
world windows64 2551584 2551696 +112
world_raws linux64 52520 52544 +24
world_raws windows64 52528 52552 +24
worldgen_parms linux64 1208 1216 +8
worldgen_parms windows64 1208 1216 +8

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@ab9rf
Copy link
Member

ab9rf commented Nov 27, 2024

we will probably want to backport the renames of creature_interaction and item_magicness to the develop branch to avoid code divergence between develop and adv-beta

@myk002
Copy link
Member

myk002 commented Nov 28, 2024

these are scary numbers. I'll do some in-game testing to sanity check

@myk002 myk002 merged commit f5b337e into DFHack:adv-beta Nov 28, 2024
13 of 17 checks passed
@quietust
Copy link
Member Author

The rename of item_magicness probably does not need to be backported - the reason I renamed it here is because its original contents are completely gone, having been replaced with something totally different, so any script which used it previously will need to be rewritten anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants