itemst vmethod update & housecleaning #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Sep 9, 2023
| <vmethod ret-type='int32_t' name='calcBaseUniformScore'/> | ||
| <vmethod><int32_t/><int32_t/><int32_t/></vmethod> | ||
| <vmethod ret-type='int32_t'> <int32_t name='race_id'/><int32_t name='caste_id'/><int32_t name='maximum'/></vmethod> |
There was a problem hiding this comment.
nope. don't know what it does
df.items.xml
Outdated
| @@ -623,46 +631,60 @@ | |||
| <pointer name='u' type-name='unit'/> | |||
| <pointer name='j' type-name='job'/> | |||
| </vmethod> | |||
| <vmethod><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/><int32_t/></vmethod> | |||
| <vmethod><int32_t/></vmethod> | |||
| <vmethod name='addImprovements'> | |||
There was a problem hiding this comment.
the code may be able to add more than one improvement, and it is parallel with the subsequent method which definitely can add multiple improvements
There was a problem hiding this comment.
ok, i reviewed the one non-trivial implementation and it only adds one improvement, so we'll drop the 's'
i originally thought it could add two in some cases, but they're on opposite side of a test and i am pretty sure there's no code path where both get added
myk002
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
identified a significant number of anonymous vmethods in
itemstalso cleaned up the index numbers in the xml, they were badly out of whack