Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Tenant Replication disabled #99

Conversation

VenkataChalla554
Copy link
Contributor

@VenkataChalla554 VenkataChalla554 commented Jun 6, 2024

Context

https://trello.com/c/OPjefUGP/1831-security-ensure-cross-tenant-replication-is-not-enabled

Changes proposed in this pull request

Added default value as false for cross_tenant_replication_enabled

Guidance to review

Tested : https://github.com/DFE-Digital/register-trainee-teachers/tree/1831-security-ensure-cross-tenant-replication-is-not-enabled

make pen deploy IMAGE_TAG=48696c5cd836b7ec49b

Storage resource has been updated : s189t01rttdbbkppensa

Before merging

After merging

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@VenkataChalla554
Copy link
Contributor Author

@VenkataChalla554 VenkataChalla554 marked this pull request as ready for review June 7, 2024 12:35
@VenkataChalla554 VenkataChalla554 merged commit 6261b2e into main Jun 7, 2024
3 checks passed
@VenkataChalla554 VenkataChalla554 deleted the 1831-security-ensure-cross-tenant-replication-is-not-enabled branch June 7, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants