Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bkp sa permissions #74

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Update bkp sa permissions #74

merged 1 commit into from
Nov 20, 2023

Conversation

RMcVelia
Copy link
Contributor

@RMcVelia RMcVelia commented Nov 20, 2023

Context

Fix permissions for the db backup storage account when it is created
https://trello.com/c/GDDsSdlZ/791-security-fix-backup-storage-account-permissions

Changes proposed in this pull request

Update the backup resource terraform definition

Guidance to review

Tested in register
You can point to this branch from any service using a bkp sa and run deploy-plan

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@RMcVelia RMcVelia force-pushed the update-sa-permissions branch from 387e7be to d6989ca Compare November 20, 2023 14:08
Disable blob anonymous access
@RMcVelia RMcVelia force-pushed the update-sa-permissions branch from d6989ca to 5f83d0e Compare November 20, 2023 14:35
@RMcVelia RMcVelia merged commit a82b454 into main Nov 20, 2023
3 checks passed
@RMcVelia RMcVelia deleted the update-sa-permissions branch November 20, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants