Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2178] Fix postgres container image version #136

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Dec 5, 2024

Context

The default postgres container image had a harcoded version number

Changes proposed in this pull request

Use var.server_version by default

Guidance to review

Tested in DFE-Digital/itt-mentor-services#1226

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

Use var.server_version by default
@saliceti saliceti added the devops label Dec 5, 2024
@saliceti
Copy link
Member Author

saliceti commented Dec 5, 2024

Copy link

@neillturner neillturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now by default the postgres docker container is consistent with server version.

@saliceti saliceti merged commit 5cbba00 into main Dec 5, 2024
3 checks passed
@saliceti saliceti deleted the 2178-postgres-default-container-image-does-not-follow-varserverversion branch December 5, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants