Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2171] Remove leading slash in URL redirect #134

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Nov 29, 2024

Context

The url_path_condition doc recommends against it

Changes proposed in this pull request

Remove the leading slash in the matched strings

Guidance to review

Tested on Register QA:
https://qa.register-trainee-teachers.service.gov.uk/security.txt
https://qa.register-trainee-teachers.service.gov.uk/.well-known/security.txt
https://qa.register-trainee-teachers.service.gov.uk/.well-known/thanks.txt
https://qa.register-trainee-teachers.service.gov.uk/thanks.txt

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

The url_path_condition doc recommends against it
@saliceti
Copy link
Member Author

@saliceti saliceti merged commit 966efba into main Nov 29, 2024
3 checks passed
@saliceti saliceti deleted the 2171-security-redirects-remove-leading-slash branch November 29, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants