Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2142] Update dfe_analytics README #133

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Nov 25, 2024

Context

Improve modules documentation

Changes proposed in this pull request

  • Clarify dfe analytics documentation
  • Add missing READMEs
  • Add tfdocs link to READMEs

Guidance to review

Review documentation

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@saliceti saliceti force-pushed the 2142-updated-dfe-analytics-readme branch from 62d5914 to 39a935e Compare November 25, 2024 17:13
@saliceti saliceti force-pushed the 2142-updated-dfe-analytics-readme branch from d34043b to 69c7d2c Compare December 9, 2024 10:52
@saliceti saliceti added the devops label Dec 9, 2024
@saliceti saliceti marked this pull request as ready for review December 9, 2024 10:54
@saliceti saliceti force-pushed the 2142-updated-dfe-analytics-readme branch from 69c7d2c to 060c515 Compare December 9, 2024 10:59
Copy link

@neillturner neillturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
just a bit of a tidy up for code samples and
some extra clarification

@saliceti
Copy link
Member Author

saliceti commented Dec 9, 2024

CCBL: migrate to GCP WIF

@saliceti saliceti merged commit 5f079b3 into main Dec 9, 2024
3 checks passed
@saliceti saliceti deleted the 2142-updated-dfe-analytics-readme branch December 9, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants