[1995] Set deployment stragegy to recreate for non web deployments #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background workers may have issues if 2 versions run at the same time. Since they don't receive user traffic, it does not matter if they are stopped while getting replaced.
gunndabad
approved these changes
Aug 22, 2024
saliceti
deleted the
1995-set-deployment-stragegy-to-recreate-for-non-web-deployments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Background workers may have issues if 2 versions run at the same time. Since they don't receive user traffic, it does not matter if they are stopped while getting replaced.
Changes proposed in this pull request
Use the Recreate deployment strategy when the deployment is not a web app
Guidance to review
Deploy DFE-Digital/apply-for-teacher-training#9742 alternatively:
make review_aks deploy PR_NUMBER=9742 IMAGE_TAG=daf97fd0483cf5e9e2d885621a209b8f3da703e5make review_aks deploy PR_NUMBER=9742 IMAGE_TAG=mainObserve pods:
watch -n 1 "kubectl -n bat-qa get pods | grep 9742"The web app creates a new one before terminating the initial one. The workers simply terminate and create.
Checklist
Devopslabel