[1839] Disable public_network_access_enabled on postgres #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The property must be set explicitly or it defaults to true. All providers have been updated to be able to use it.
shaheislamdfe
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related to issue: hashicorp/terraform-provider-azurerm#26098
The property must be set explicitly or it defaults to true. All providers have been updated to be able to use it.
Changes proposed in this pull request
Guidance to review
Test branch 1839-temp on ECF
make production terraform-plan CONFIRM_PRODUCTION=y DOCKER_IMAGE=ghcr.io/dfe-digital/early-careers-framework:a9ed25957fb1190234e8289c71576611a401833eshould show no change to postgres
Before merging
Make sure all providers have been updated
Checklist
Devopslabel