Added alert frequency monitor metric #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenkataChalla554
force-pushed
the
1927-allow-metric-frequency-override
branch
3 times, most recently
from
f95db4f to
8170f36
Compare
saliceti
reviewed
Jul 26, 2024
saliceti
force-pushed
the
1927-allow-metric-frequency-override
branch
2 times, most recently
from
3392a20 to
2f6ee50
Compare
The default 1 minute interval between checks doesn't work for window sizes that are more than 4h. Increase to 5 minutes for 6h and 12h.
saliceti
force-pushed
the
1927-allow-metric-frequency-override
branch
from
2f6ee50 to
4a175da
Compare
saliceti
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Set frequency based on alert window size
Changes proposed in this pull request
Set frequency to azurerm_monitor_metric_alert based on alert window size.
Guidance to review
Tested on test branch : https://github.com/DFE-Digital/publish-teacher-training/tree/1927-allow-metric-frequency-override-test.
run terraform plan : make staging_aks deploy-plan IMAGE_TAG=96adb7639cb29bb97616939b88fc3e65aa3485a1.
it showed updating frequency as below for "alert_window_size": "PT1H"
~ frequency = "PT1M" -> "PT30M"
Before merging
After merging
Checklist
Devopslabel